Skip to content

Terms Query: Show nested terms toggle when inheriting #72510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 23, 2025
Merged

Terms Query: Show nested terms toggle when inheriting #72510

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3f1e1a7
Show nested terms toggle when inheriting
mikachan Oct 21, 2025
ae169b1
Update help text
mikachan Oct 21, 2025
0b47a8a
Update help text based on feedback
mikachan Oct 21, 2025
3752755
Update logic to fetch correct terms
mikachan Oct 21, 2025
1f382a2
Merge branch 'trunk' into update/terms-inherit-nested
mikachan Oct 21, 2025
546598a
Remove new editor logic
mikachan Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-library/src/terms-query/edit/inspector-controls/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ export default function TermsQueryInspectorControls( {
templateSlug?.startsWith( 'taxonomy-' ) ||
templateSlug?.startsWith( 'category-' ) ||
templateSlug?.startsWith( 'tag-' );
// Only display the showNested control if the taxonomy is hierarchical and not inheriting.
const displayShowNestedControl = isTaxonomyHierarchical && ! inheritQuery;
// Display the showNested control if the taxonomy is hierarchical.
const displayShowNestedControl = isTaxonomyHierarchical;
const hasIncludeFilter = !! include?.length;

// Labels shared between ToolsPanelItem and its child control.
Expand Down
4 changes: 1 addition & 3 deletions packages/block-library/src/terms-query/edit/inspector-controls/inherit-control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,12 @@ export default function InheritControl( { value, onChange, label } ) {
onChange={ ( newValue ) => {
onChange( {
inherit: newValue === 'default',
// When enabling inherit, hierarchical is not supported.
...( newValue === 'default' ? { showNested: false } : {} ),
} );
} }
help={
value
? __(
'Display terms based on the current taxonomy archive. For hierarchical taxonomies, shows direct children of the current term. For non-hierarchical taxonomies, shows all terms.'
'Display terms based on the current taxonomy archive. For hierarchical taxonomies, choose between showing nested terms or only direct children.'
)
: __( 'Display terms based on specific criteria.' )
}
Expand Down
Loading