Skip to content

WIP: Add spacing presets UI #72301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

WIP: Add spacing presets UI #72301

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26b1032
Add spacing presets UI
juanfra Oct 13, 2025
132eb45
Fix PHPCS errors.
juanfra Oct 13, 2025
067892d
Update comment.
juanfra Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PHPCS errors.
  • Loading branch information
@juanfra
juanfra committed Oct 13, 2025
commit 132eb45c7260c9027f3a46852624c66801ffc21f
8 changes: 4 additions & 4 deletions lib/block-supports/spacing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
*
* @return string|null Spacing size value or `null` if a size is not passed in $preset.
*/
function gutenberg_get_spacing_size_value( $preset, $settings = array() ) {

Check warning on line 94 in lib/block-supports/spacing.php

View workflow job for this annotation

GitHub Actions / PHP coding standards 

Unused function parameter $settings.
if ( ! isset( $preset['size'] ) ) {
return null;
}
Expand Down Expand Up @@ -124,12 +124,12 @@

// Build clamp() only when explicit min/preferred/max are provided via fluid object.
if ( is_array( $fluid_spacing_settings ) && ! empty( $fluid_spacing_settings ) ) {
$min = isset( $fluid_spacing_settings['min'] ) ? trim( (string) $fluid_spacing_settings['min'] ) : '';
$preferred = isset( $fluid_spacing_settings['preferred'] ) ? trim( (string) $fluid_spacing_settings['preferred'] ) : trim( (string) $size );
$max = isset( $fluid_spacing_settings['max'] ) ? trim( (string) $fluid_spacing_settings['max'] ) : '';
$min = isset( $fluid_spacing_settings['min'] ) ? trim( (string) $fluid_spacing_settings['min'] ) : '';
$preferred = isset( $fluid_spacing_settings['preferred'] ) ? trim( (string) $fluid_spacing_settings['preferred'] ) : trim( (string) $size );
$max = isset( $fluid_spacing_settings['max'] ) ? trim( (string) $fluid_spacing_settings['max'] ) : '';

// All three are required to form a valid clamp().
if ( $min !== '' && $preferred !== '' && $max !== '' ) {
if ( '' !== $min && '' !== $preferred && '' !== $max ) {
return sprintf( 'clamp(%s, %s, %s)', $min, $preferred, $max );
}
}
Expand Down
Loading