Skip to content

Table of Contents: Add aria label to the nav element #71586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 25, 2025
Merged

Table of Contents: Add aria label to the nav element #71586

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
827c0a3
Added aria label to the nav element
MaggieCabrera Sep 10, 2025
ef9f831
fixed fixtures to include the new attr
MaggieCabrera Sep 10, 2025
9bd08b7
Update edit.js
mikachan Sep 23, 2025
15848d4
Update save.js
mikachan Sep 23, 2025
1536e44
Merge branch 'trunk' into toc-aria-label
mikachan Sep 23, 2025
94942db
Try server-side rendering the block
mikachan Sep 23, 2025
efb3b7a
Fix coding standards errors
mikachan Sep 24, 2025
e03920d
Simplify server-side approach
mikachan Sep 24, 2025
80f8cb2
Regenerate test fixtures
mikachan Sep 24, 2025
14496a2
Simplify $aria_label
mikachan Sep 24, 2025
276f4fe
Restore test fixtures
mikachan Sep 24, 2025
9eb29a4
Revert changes to other test fixtures
mikachan Sep 24, 2025
672461d
Update packages/block-library/src/table-of-contents/index.php
Mamaduka Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update save.js
  • Loading branch information
@mikachan
mikachan committed Sep 23, 2025
commit 15848d446f22bd55bc3a2ae4e1e85ea6834ac162
8 changes: 2 additions & 6 deletions packages/block-library/src/table-of-contents/save.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,19 @@
* WordPress dependencies
*/
import { useBlockProps } from '@wordpress/block-editor';
import { __ } from '@wordpress/i18n';

/**
* Internal dependencies
*/
import TableOfContentsList from './list';
import { linearToNestedHeadingList } from './utils';

export default function save( { attributes: { headings = [], ariaLabel } } ) {
export default function save( { attributes: { headings = [] } } ) {
if ( headings.length === 0 ) {
return null;
}
return (
<nav
{ ...useBlockProps.save() }
aria-label={ ariaLabel || __( 'Table of Contents' ) }
>
<nav { ...useBlockProps.save() }>
<ol>
<TableOfContentsList
nestedHeadingList={ linearToNestedHeadingList( headings ) }
Expand Down