Skip to content

Handle label fallback for dropdownMenu #70951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2025
+4 −1
Merged

Handle label fallback for dropdownMenu #70951

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c5e8c2
fix: Show correct label when prop has label key in it
im3dabasia Jul 29, 2025
aa643f4
fix: Omit label prop in dropdownprops
im3dabasia Jul 31, 2025
bc78b61
Merge branch 'trunk' into try/dropdownMenuProps-label-fix
mirka Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/components/src/tools-panel/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ export type ToolsPanelHeaderProps = {
/**
* The dropdown menu props to configure the panel's `DropdownMenu`.
*/
dropdownMenuProps?: React.ComponentProps< typeof DropdownMenu >;
dropdownMenuProps?: Omit<
React.ComponentProps< typeof DropdownMenu >,
'label'
>;
Comment on lines -80 to +83
Copy link
Contributor

@t-hamano t-hamano Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this format is correct, but I don't know how to describe it in the README 😅

gutenberg/packages/components/src/tools-panel/tools-panel-header/README.md

Line 25 in 53b643c

- Type: `DropdownMenuProps`

cc @WordPress/gutenberg-components

Additionally, I think we need to update here as well:

gutenberg/packages/components/src/tools-panel/types.ts

Line 23 in 53b643c

dropdownMenuProps?: React.ComponentProps< typeof DropdownMenu >;

Copy link
Member

@mirka mirka Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to describe it in the README 😅

Mm, I'm fine with this for now, it's not crucial information. And we won't have to think about this once these are converted to an autogenerated readme!

/**
* The heading level of the panel's header.
*
Expand Down
Loading