Skip to content

Components: Replace/old custom select control with v2 legacy adapter #61272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Components: Replace/old custom select control with v2 legacy adapter #61272

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cc17f9f
Replace old `CustomSelectControl` select control with the V2 legacy a…
fullofcaffeine Apr 18, 2024
33bb57d
Fix option handling logic for legacy adater and update test to reflec…
fullofcaffeine May 10, 2024
f2c059c
Remove debug code
fullofcaffeine May 11, 2024
0e83151
Debug why selectedItem is not selected on mount
fullofcaffeine May 14, 2024
db8379a
Ensure correct item is selected upon mount based on the value passed …
fullofcaffeine May 15, 2024
751b295
Add new test case to make sure initial passed value is selected upon …
fullofcaffeine May 16, 2024
d18f88d
CSS tweaks
fullofcaffeine May 16, 2024
218cc67
More CSS adjustments to make the component behave closer to classic
fullofcaffeine May 16, 2024
ee619f0
Remove unused prop
fullofcaffeine May 16, 2024
ac751d9
Fix experimentalHint custom styling on legacy adapter
fullofcaffeine May 17, 2024
0db8e28
Fix width of popover not always matching the width of the select
fullofcaffeine May 17, 2024
98a0fc4
Improve export name
fullofcaffeine May 17, 2024
e88b0c4
Fix label margin not applying in certain contexts
fullofcaffeine May 18, 2024
d2cfd1d
Add a wrapper around the select as it the main container needs to hav…
fullofcaffeine May 18, 2024
e47adcf
Fix withHint handling
fullofcaffeine May 18, 2024
e38a4c8
Fix tests
fullofcaffeine May 18, 2024
17f6bbd
Revert accidental change
fullofcaffeine May 18, 2024
cd537af
Make the select item text non-selectable
fullofcaffeine May 21, 2024
fd5c051
Merge branch 'trunk' into replace/old-custom-select-control-with-v2-l…
fullofcaffeine May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused prop
  • Loading branch information
@fullofcaffeine
fullofcaffeine committed May 27, 2024
commit ee619f0a2a5f2379f0a9bd36d669da169c193254
7 changes: 1 addition & 6 deletions packages/components/src/custom-select-control-v2/custom-select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,7 @@ function _CustomSelect( props: _CustomSelectProps & CustomSelectStore ) {
</Styled.SelectLabel>
) }
<CustomSelectButton { ...restProps } store={ store } />
<Styled.SelectPopover
gutter={ 12 }
store={ store }
sameWidth
fitViewport
>
<Styled.SelectPopover gutter={ 12 } store={ store } sameWidth>
<CustomSelectContext.Provider value={ { store } }>
{ children }
</CustomSelectContext.Provider>
Expand Down