Skip to content

SlotFill: Migrate to Typescript. #51350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Sep 28, 2023
Merged

SlotFill: Migrate to Typescript. #51350

Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
a0bbcbf
convert typescript slot-fill-context.ts and slot-fill-provider.tsx
torounit Jun 8, 2023
353f3bf
fix portalContainer type.
torounit Jun 8, 2023
46e4983
convert hooks to ts.
torounit Jun 8, 2023
49b7807
fix types
torounit Jun 8, 2023
f7f3c07
fix fillProps
torounit Jun 8, 2023
e7dbaf1
convert slot.tsx
torounit Jun 8, 2023
f3d474f
update Fill
torounit Jun 8, 2023
e4f205c
fix typename.
torounit Jun 8, 2023
94219ca
fix dropdown v2 portal container type.
torounit Jun 8, 2023
83466fc
fix ref type
torounit Jun 8, 2023
e333f1b
refactor
torounit Jun 8, 2023
681a0e8
refactor SlotFillProvider
torounit Jun 9, 2023
c7419ed
migrate SlotComponent to TS
torounit Jun 9, 2023
7703647
convert useSlot
torounit Jun 10, 2023
7862088
add update
torounit Jun 21, 2023
e03bc11
fix ProviderProps
torounit Jun 21, 2023
b50ae79
refactor type
torounit Jun 22, 2023
4e0a665
refactor type
torounit Jun 22, 2023
499f8bd
allow symbol to name prop.
torounit Jun 22, 2023
228fd5f
refactor SlotComponentProps
torounit Jun 22, 2023
fe872f9
refactor stroies and README
torounit Jun 22, 2023
ebfd7f3
fix typo
torounit Jun 22, 2023
bbffb58
remove comments. remove children from Slot.
torounit Jun 22, 2023
1182668
refactor SlotComponentProps
torounit Jun 23, 2023
e5a828e
Apply suggestions from code review
torounit Jul 1, 2023
79951ea
Apply suggestions from code review
torounit Jul 1, 2023
4deef29
refactor: newChildren to inline.
torounit Jul 3, 2023
5e26c79
Remove unnecessary type variables.
torounit Jul 4, 2023
0f6d79c
fix type comments
torounit Jul 5, 2023
46ff121
Remove unnecessary Type Guards. Remove unnecessary Type Guards. And u…
torounit Jul 8, 2023
68f277c
remove type from jsdoc
torounit Jul 15, 2023
cf48aee
refactor types
torounit Jul 15, 2023
9695182
refactor types
torounit Jul 15, 2023
09b23ce
Simplify the type of `slot`.
torounit Jul 15, 2023
d515975
Remove the type specification and leave it to type inference.
torounit Jul 22, 2023
d650f5f
fix types
torounit Sep 6, 2023
3b12a6d
remove story.js
torounit Sep 6, 2023
191a45d
update changelog
torounit Sep 6, 2023
82349c0
remove ts-nocheck
torounit Sep 8, 2023
78ab5e7
fix story filename. remove override bubblesVirtually attribute
torounit Sep 8, 2023
821f4d4
replace useState to useMemo
torounit Sep 9, 2023
0607a32
switch to ts-expect-error in story.
torounit Sep 9, 2023
81bd81d
fix mssing changelog https://github.com/WordPress/gutenberg/pull/5327…
torounit Sep 19, 2023
2e7e367
add `children?: never` https://github.com/WordPress/gutenberg/pull/51…
torounit Sep 19, 2023
d5773d4
use Record
torounit Sep 20, 2023
f169e67
use Record / Enable className only when bubblesVirtually: true.
torounit Sep 20, 2023
2cc685f
Update packages/components/src/slot-fill/types.ts
torounit Sep 24, 2023
31ba069
update changelog
torounit Sep 24, 2023
656a45d
use optional chain
torounit Sep 28, 2023
ff18ed5
fix WordPressComponentProps import
torounit Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update changelog
  • Loading branch information
@torounit
torounit committed Sep 28, 2023
commit 191a45d4b4d8d6a2a9996f0fb0f4e330e7d455c2
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
- `Button`: Update documentation to remove the button `focus` prop ([#54397](https://github.com/WordPress/gutenberg/pull/54397)).
- `Toolbar/ToolbarGroup`: Convert component to TypeScript ([#54317](https://github.com/WordPress/gutenberg/pull/54317)).
- `Modal`: add more unit tests ([#54569](https://github.com/WordPress/gutenberg/pull/54569)).
- `SlotFill`: Migrate to TypeScript and Convert to Functional Component `<Slot bubblesVirtually />`. ([#51350](https://github.com/WordPress/gutenberg/pull/51350)).

### Experimental

Expand Down