Skip to content

Migrate Adding Inline Token test to Playwright #50844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Migrate Adding Inline Token test to Playwright #50844

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2922a8
Migrate Adding Inline Token test to Playwright
pooja-muchandikar May 22, 2023
bb5f4ed
Add space
pooja-muchandikar May 22, 2023
211429b
Address Feedbacks
pooja-muchandikar Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 21 additions & 33 deletions ...itor/various/adding-inline-tokens.test.js → ...itor/various/adding-inline-tokens.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,33 +9,26 @@ import { v4 as uuid } from 'uuid';
/**
* WordPress dependencies
*/
import {
clickBlockAppender,
getEditedPostContent,
createNewPost,
clickBlockToolbarButton,
clickButton,
pressKeyWithModifier,
} from '@wordpress/e2e-test-utils';
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' );

describe( 'adding inline tokens', () => {
beforeEach( async () => {
await createNewPost();
test.describe( 'adding inline tokens', () => {
test.beforeEach( async ( { admin } ) => {
await admin.createNewPost();
} );

it( 'should insert inline image', async () => {
test( 'should insert inline image', async ( {
page,
editor,
pageUtils,
} ) => {
// Create a paragraph.
await clickBlockAppender();
await page.click( 'role=button[name="Add default block"i]' );
await page.keyboard.type( 'a ' );

await clickBlockToolbarButton( 'More' );
await clickButton( 'Inline image' );
await editor.showBlockToolbar();
await page.click( 'role=button[name="More"i]' );
await page.click( 'role=menuitem[name="Inline image"i]' );

// Wait for media modal to appear and upload image.
// Wait for media modal to appear and upload image.
const inputElement = await page.waitForSelector(
'.media-modal .moxie-shim input[type=file]'
);
const testImagePath = path.join(
__dirname,
'..',
Expand All @@ -47,26 +40,21 @@ describe( 'adding inline tokens', () => {
const filename = uuid();
const tmpFileName = path.join( os.tmpdir(), filename + '.png' );
fs.copyFileSync( testImagePath, tmpFileName );
await inputElement.uploadFile( tmpFileName );

// Wait for upload.
await page.waitForSelector(
`.media-modal li[aria-label="${ filename }"]`
);
await page
.locator( '.media-modal .moxie-shim input[type=file]' )
.setInputFiles( tmpFileName );

// Insert the uploaded image.
await page.click( '.media-modal button.media-button-select' );
await page.click( 'role=button[name="Select"i]' );

// Check the content.
const regex = new RegExp(
`<!-- wp:paragraph -->\\s*<p>a <img class="wp-image-\\d+" style="width:\\s*10px;?" src="[^"]+\\/${ filename }\\.png" alt=""\\/?><\\/p>\\s*<!-- \\/wp:paragraph -->`
);
expect( await getEditedPostContent() ).toMatch( regex );
expect( await editor.getEditedPostContent() ).toMatch( regex );
Copy link
Member

@kevin940726 kevin940726 Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's instead do something like:

const contentRegex = new RegExp(
	`a <img class="wp-image-\\d+" style="width:\\s*10px;?" src="[^"]+\\/${ filename }\\.png" alt=""\\/?>`
);
await expect.poll( editor.getBlocks ).toMatchObject( [ {
	name: 'core/paragraph',
	attributes: { content: expect.stringMatching( contentRegex ) }
} ] );


await pageUtils.pressKeys( 'shift+ArrowLeft' );

await pressKeyWithModifier( 'shift', 'ArrowLeft' );
await page.waitForSelector(
'.block-editor-format-toolbar__image-popover'
);
await page.keyboard.press( 'Tab' );
await page.keyboard.press( 'Tab' );
await page.keyboard.type( '20' );
Expand All @@ -76,6 +64,6 @@ describe( 'adding inline tokens', () => {
const regex2 = new RegExp(
`<!-- wp:paragraph -->\\s*<p>a <img class="wp-image-\\d+" style="width:\\s*20px;?" src="[^"]+\\/${ filename }\\.png" alt=""\\/?><\\/p>\\s*<!-- \\/wp:paragraph -->`
);
expect( await getEditedPostContent() ).toMatch( regex2 );
expect( await editor.getEditedPostContent() ).toMatch( regex2 );
Copy link
Member

@kevin940726 kevin940726 Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with a similar change.

} );
} );