Improve consistency across color and gradient panels #46513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Contributor
|
Good one, thank you for the PR, definitely want to make progress on these. On the one hand, the custom color swatch was designed to be a specific height to add some character and not just be a rectangle. On the other hand, if the gradient box becomes taller, the padding around the left/right handles needs to increase to match this particular design where the gradient actually starts a bit indented from the edges. Tricky to reconcile those two easily. Similarly, we're hoping to implement a standard 40px controls grid across the board. Just looking at that, the 48px size of the gradient control oddly stands out as not quite taller enough than 40px that it might as well be 40px, or taller, such as 60px. Both tricky in their own right. Another aspect is the borders: in the case of the swatches and colors, they are arguably needed, especially when the color white is involved. But the border around the gradient box was specifically omitted because there are so many borders everywhere already. All of that is not to block the specific improvements here from landing, just that if @pablohoneyhoney has a moment to chime in, I'd love input. Otherwise, let's find a way forward! Speaking of progress, it would be nice to revisit the gradient markers too — their style and even focus could use some love. I like the new focal point picker, perhaps some DNA can be shared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Improve consistency across the color and gradient panels, which also reduces the UI jump when selecting the Gradient tab.
How?
Style tweaks.
Testing Instructions
Screenshots or screencast
Before
After