Connect Refresh: Remove JP-Connect signup (create-account) components completely

[chriskmnds]

Part of https://linear.app/a8c/issue/DOTCOM-13218/signup-update-and-unify-the-account-creation-screens
Part of https://linear.app/a8c/issue/DOTCOM-14131/signup-woojpc-and-woodna-update-create-an-account-screen
Follows up from #105156

Proposed Changes

The JP Connect flow renders its own Signup components as part of its routing middleware. As of #105135 for Woo JPC & Woo DNA we no longer utilise these components. We instead redirect to /start/account and back so signup happens through our standardised Signup frameworks.

We remove these componenets completely and make the redirection the default/only behavior. I cannot think of a reason to keep importing and signing up users through JP Connect directly.

Why are these changes being made?

Part of https://linear.app/a8c/issue/DOTCOM-13218/signup-update-and-unify-the-account-creation-screens
Part of https://linear.app/a8c/issue/DOTCOM-14131/signup-woojpc-and-woodna-update-create-an-account-screen
Follows up from #105156

Testing Instructions

I am not sure how these components are utilised outside of Woo JPC. Assuming nothing else currently requires the JP signup form, then we should be good to deploy when build passes.

The route that consumes the JP Signup form is: /jetpack/connect/authorize

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-152728

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-152728&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-152728&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center
• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/connect-refresh-signup-unify-remove-jpc-signup on your sandbox.

[raicem]

This works great and code changes look good! I'm able to connect my site to Jetpack when I'm not logged, logged in or with a newly created account.

Creating an account flow shows one possible regression:

Creating a new account takes me to the new page now but we lose of the Jetpack branding. On the left is production, on the right is this branch. This was the case for WooJPC as well but switching from the Jetpack green made it really obvious

Tested as:

• Start a test site
• Make sure you are logged out of WordPress.com
• Go to wp-admin > Jetpack and find a CTA to connect
• Clicking the CTA, replace the URL from wordpress.com to calypso.localhost:3000
• See the create account screen

[chriskmnds]

Thanks @raicem for the testing and insights! Appreciate the details. When you mention:

This was the case for WooJPC as well but switching from the Jetpack green made it really obvious

Just to make sure - do you mean the same raw create-account page was rendered for WooJPC as well? I think we get the properly unified one in that case, right? (otherwise it must be some parameter missing to not be passing the isWooJPC checks) 🤔

For the Jetpack one, we probably need to pass a parameter is-jetpack to pick up the JP unified page (because it's not a OAuth2 client in that case - I think?)

[raicem]

Just to make sure - do you mean the same raw create-account page was rendered for WooJPC as well? I think we get the properly unified one in that case, right?

Indeed, it was properly unified and had no issues at all. WooJPC styling is way more subtle, and redirecting to unified signup looks OK.

Redirecting Jetpack login to unified signup looks more drastic. Suddenly, Jetpack green is gone. So I wanted to highlight that bit. It was not a blocker to merge the PR.

we probably need to pass a parameter is-jetpack to pick up the JP unified page

I flipped isJetpack to true on this line but I'm not seeing any theming on the sign up page (URL)

[github-actions]

This PR has been marked as stale. This happened because:

• It has been inactive for the past 3 months.
• It hasn't been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Status] Keep Open`, etc.

If this PR is still useful, please do a trunk merge or rebase and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.