-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix Storybook compilation in components package #103362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
jsnajdr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 The /styles/* path exports only define the calypso:src condition, so a webpack compilation must have it in conditionNames.
On that note, should it be that we only export the |
* Add conditionNames for Storybook Webpack build
* flip the flag * Fix stats-navigation tab selectors for tests * Stats: Fix e2e tests by handling new selectors for the new nav header (#103384) * Add a new utility function for clicking on new navigation * Handle selectors for the new navigation header in e2e tests * Don't update the selector for other tests apart from stats * Adjust styling for summary nav on mobile (#103363) * Remove `preventWidows` from `client/components` (#103187) * Remove `preventWidows` from `client/components` * CardHeading * VisibleDaysLimitUpsell * Add new site for A4A and add styles * Remove preventWidows and disablePreventWidows from FormattedHeader * Happiness support * BackupGettingStarted * JetpackProductCardFeaturesItem * JetpackProductCard * Jetpack backups * Backup successful * IntroPricingBanner * JetpackDisconnected * JetpackDisconnectedWPCOM * LicensingActivation * PurchaseDetail * SeoPreviewNudge * Add new site popover * theme collection * Update test snapshots * Fix Storybook compilation in components package (#103362) * Add conditionNames for Storybook Webpack build * Editor: Stop preloading section (#103334) * Editor: Stop preloading section * Get rid of actionHoverCallback * Breadcrumbs: Add `renderItemLink ` prop (#103321) * SummaryButton: Add `renderLink` prop * Rename to renderItemLink, split Item vs BreadcrumbsItemProps, refactor implementation * Prevent flickering in Storybook when opning menu in compact mode * Add open for extension to docs * add a test and console.log in story * feedback --------- Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> * Update different A4A labels to sentence case (#103238) * Update different A4A labels to sentence case * Fix one more occurence * Showing multiple domain selection on new-hosted-site flow (#103359) * E2E Auth: Fix apple login flow to wpcom and woo (#103357) * Encript updated path * E2E auth apple: fix wpcom and woo auth flows * Follow up of #103321 (#103382) * WooCoreProfilerMasterbar: fix useSelector and useTranslate usages (#103373) * Fix/stop import redirect after failed wix (#103358) * Redirect to the correct step when a wix migration fails * remove hardcoded true --------- Co-authored-by: Andrés Blanco <email@gmail.com> * Notifications settings: change Publicized copy (#103265) * change copy for Jetpack Social notification setting (formerly Publicized) * do not translate brand name * Improves the design for the Migration Requested page (#103183) * Improves the design for the Migration Requested page * Remove card borders * A4A: Fix the background color (#103389) * Revert "Notifications settings: change Publicized copy (#103265)" (#103392) This reverts commit c320da3. * Apps: Fix Odyssey translation extraction. (#103393) * change Publicized copy to Jetpack Social brand, add translators comment (#103395) * Fix e2e onboarding new hosted site tests (#103383) * Upgrade importers to container v2 (#103024) * Upgrade importers to container v2 * remove test string * show title inside the import drag if not using container v2 * fix heading wp importer * fix progressbar * hacky but working * apply Gabriel's suggestions --------- Co-authored-by: Andrés Blanco <email@gmail.com> * Apps: Fix Odyssey widget reactivity. (#103400) * STATS-64: Don't dispatch legacy country data (#103376) * STATS-67 - Don't navigate to the current tab if we are already on the current tab (#103379) * STATS-67: Don't reload page if current tab is already the selected tab * Add comment as to why the tab selected conditionally * Stats: Fix styling on Odyssey Stats for Navigation Improvement (#103369) * Fix main navigation mobile dropdown item padding * Make mobile summary nav dropdown 100% width * Fix Locations summary mobile item list label padding * Fix stats-navigation tab selectors for tests * Stats: Fix e2e tests by handling new selectors for the new nav header (#103384) * Add a new utility function for clicking on new navigation * Handle selectors for the new navigation header in e2e tests * Don't update the selector for other tests apart from stats * remove has-fixed-nav when new nav enabled * avoid loading style conflicts --------- Co-authored-by: Nikhil <Nikschavan@users.noreply.github.com> Co-authored-by: Dognose <dognose24@gmail.com> Co-authored-by: Dognose <dognose24@users.noreply.github.com> Co-authored-by: tellthemachines <tellthemachines@users.noreply.github.com> Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me> Co-authored-by: Paulo Marcos Trentin <paulo@paulotrentin.com.br> Co-authored-by: Bogdan Nikolic <bogdan.nikolic87@gmail.com> Co-authored-by: Jarda Snajdr <jsnajdr@gmail.com> Co-authored-by: Andrés Blanco <andresblanco@gmail.com> Co-authored-by: Andrés Blanco <email@gmail.com> Co-authored-by: Christian Gastrell <cgastrell@gmail.com> Co-authored-by: valterlorran <valterlorran@hotmail.com> Co-authored-by: arthur791004 <arthur.chu@automattic.com> Co-authored-by: sdnunca <sorin.nunca@automattic.com>
When I was adding the additional (non-root) exports I was primarily fixing Calypso compilation errors, and for that the The
|
Related to #103103
Proposed Changes
@automattic/componentspackage by ensuring that Calypso's Webpack-based Storybook compilation is able to match thecalypso:srcexports, usingconditionNames(similar to what we do in the main client compilation).Why are these changes being made?
Testing Instructions
Verify both Storybook build produces no errors:
Pre-merge Checklist