-
Notifications
You must be signed in to change notification settings - Fork 843
Forms: Use Core buttons instead of Jetpack buttons #45007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lezama
wants to merge
16
commits into
trunk
Choose a base branch
from
feature/replace-jetpack-buttons-with-core-buttons
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+496
−63
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
57725d7
Switch contact form submit button to core/buttons block
lezama 8066c25
simpler
lezama 05e4398
Restrict flex styling to specific wp-block elements
lezama bed35f0
Add spinner animation for submitting form button
lezama dfdbd59
Restrict tag processing to button and update submit styles
lezama 57e1c87
changelog
lezama 80d8670
Update projects/packages/forms/src/blocks/contact-form/variations.js
lezama 00d63f9
Refactor render_submit_button to improve clarity
lezama 3f1849f
Update projects/packages/forms/src/blocks/contact-form/variations.js
lezama 7aee2f9
add some tests to improve coverage
CGastrell 46c0779
fix disabled and submitting states
CGastrell 12c24bb
update tests after attribute addition
CGastrell c7684da
modify useformwrapper to use core/buttons as well
CGastrell 2bfc41f
Apply suggestion from @manzoorwanijk
lezama 7102244
Update projects/packages/forms/src/blocks/contact-form/class-contact-…
lezama fac10d5
change patterns to use core buttons
CGastrell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add some tests to improve coverage
- Loading branch information
commit 7aee2f9b89cb1d63a6f69537138ad33e33f4289b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.