Detect if running phar via CLI SAPI #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GDR! <gdr@gdr.name>
danielbachhuber
approved these changes
Nov 29, 2022
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
👍 Looks fine to me. I'll get a second opinion from @schlessera though.
schlessera
requested changes
Dec 9, 2022
Member
schlessera
left a comment
There was a problem hiding this comment.
Great addition to ensure people don't need to hunt down bogus errors.
I've just rephrased the text a bit trying to make it more precise and friendly.
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Contributor
Author
|
Much better wording, thank you @schlessera |
schlessera
approved these changes
Dec 9, 2022
Member
|
Thanks for the PR, @gjedeer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GDR! gdr@gdr.name
Closes wp-cli/wp-cli#5703
The PHAR build did not detect if cgi or fcgi SAPI has been used, and instead crashed with a hard to debug message.