Skip to content

Conversation

@ernilambar
Copy link
Member

This PR removes following code from theme-bootstrap.mustache:

if ( PHP_MAJOR_VERSION >= 8 ) {
	echo "The scaffolded tests cannot currently be run on PHP 8.0+. See https://github.com/wp-cli/scaffold-command/issues/285" . PHP_EOL; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
	exit( 1 );
}

While working on #331 I noticed this conditional is now not needed.

CC @schlessera - Ref #285

@ernilambar ernilambar marked this pull request as ready for review April 15, 2024 09:45
@ernilambar ernilambar requested a review from a team as a code owner April 15, 2024 09:45
@swissspidy swissspidy merged commit e4be9fe into wp-cli:main Apr 26, 2024
@swissspidy swissspidy added this to the 2.3.0 milestone Apr 26, 2024
@ernilambar ernilambar deleted the update/theme-bootstrap branch August 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants