Skip to content

Conversation

@ernilambar
Copy link
Member

Fixes #116

  • Uses wp_get_registered_image_subsizes() for fetching image size information

@ernilambar ernilambar requested a review from a team as a code owner February 22, 2024 08:30
@swissspidy
Copy link
Member

Can we add a test verifying this behavior? Should be possible to add & activate a small plugin that registers additional image sizes, then run the command.

@ernilambar
Copy link
Member Author

@swissspidy Can you please run Behat test manually in GitHub action?

@swissspidy swissspidy closed this Feb 22, 2024
@swissspidy swissspidy reopened this Feb 22, 2024
@swissspidy
Copy link
Member

Oh, looks like the workflow was disabled due to inactivity

@swissspidy swissspidy closed this Feb 22, 2024
@swissspidy swissspidy reopened this Feb 22, 2024
@swissspidy swissspidy marked this pull request as draft February 22, 2024 11:39
@swissspidy swissspidy marked this pull request as ready for review February 22, 2024 11:39
@ernilambar
Copy link
Member Author

CC @danielbachhuber

@schlessera schlessera added this to the 2.1.0 milestone Mar 14, 2024
@schlessera schlessera merged commit 210cccf into wp-cli:main Mar 14, 2024
@schlessera
Copy link
Member

Thanks, @ernilambar !

@schlessera schlessera changed the title Fix incorrect image sizes in media image-size command Fix incorrect image sizes in media image-size command Mar 14, 2024
@ernilambar ernilambar deleted the 116-fix-image-size branch March 14, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image-Size list shows custom image sizes twice

4 participants