wp media regenerate for PDF thumbnails

[MattFCP]

Feature Request

I haven't been able to find a way to regenerate PDF thumbnails. Reason I'm trying to is there must have been a bug in WordPress 5 that stopped this from working. It seems to be working now, but I have 50 or so pdfs that I need to regenerate thumbnails for. I tried WP-CLI command "wp media regenerate IMAGEID" and for PDFs it returns the error "No images found". While it works for regular images, it would be nice for this to work for PDFs as well.

Thanks,
Matt

[danielbachhuber]

Thanks for the report, @MattFCP !

Were you able to track this issue down? Can you share more steps to reproduce? Did your 50 original PDFs have thumbnails, or were they missing entirely?

The "No images found" error happens here:

media-command/src/Media_Command.php

Lines 133 to 139 in 49ef52c

	$images = $this->get_images( $args, $additional_mime_types );
	$count = $images->post_count;
	if ( ! $count ) {
	WP_CLI::warning( 'No images found.' );
	return;
	}

WP-CLI is simply querying post objects from the database, though:

media-command/src/Media_Command.php

Lines 925 to 945 in 49ef52c

	/**
	* Get images from the installation.
	*
	* @param array $args The query arguments to use. Optional.
	* @param array $additional_mime_types The additional mime types to search for. Optional.
	*
	* @return WP_Query The query result.
	*/
	private function get_images( $args = array(), $additional_mime_types = array() ) {
	$mime_types = array_merge( array( 'image' ), $additional_mime_types );
	$query_args = array(
	'post_type' => 'attachment',
	'post__in' => $args,
	'post_mime_type' => $mime_types,
	'post_status' => 'any',
	'posts_per_page' => -1,
	);
	return new WP_Query( $query_args );
	}

The error would imply that the post objects don't exist.