Skip to content

Bail with status code if file does not exist #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 11, 2022
Merged

Bail with status code if file does not exist #75

merged 8 commits into from
Sep 11, 2022

Conversation

@lucatume
Copy link
Contributor

@lucatume lucatume commented Jun 2, 2022 •
edited
Loading

This PR includes the original code from #74 to add tests.

  • Check if file exists and bail if not
  • Check if file exists
  • Improved error handling and warning messages
  • Fix typo
  • Improve warning message
  • Update feature to cover non existing files/dirs.

@lucatume lucatume requested a review from a team as a code owner June 2, 2022 12:45
@lucatume lucatume mentioned this pull request Jun 2, 2022
Closed
lucatume
lucatume commented Sep 8, 2022
View reviewed changes
Copy link
Contributor Author

@lucatume lucatume left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong comment.

@schlessera schlessera force-pushed the bail-with-status-code-if-file-doesnt-exits branch from 0a7f90d to c269d55 Compare September 11, 2022 19:33
@schlessera schlessera added this to the 2.0.9 milestone Sep 11, 2022
@schlessera schlessera changed the title Wrap #74 to add tests Bail with status code if file does not exist Sep 11, 2022
@schlessera schlessera merged commit 9cc7f5b into wp-cli:master Sep 11, 2022
@schlessera schlessera mentioned this pull request Sep 11, 2022
Closed
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
@schlessera
Merge pull request #75 from lucatume/bail-with-status-code-if-file-do…
3578a74 
…esnt-exits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

bug command:import

Projects

None yet

Milestone

2.0.9

Development

Successfully merging this pull request may close these issues.

3 participants

@lucatume @schlessera @stoyan-g