Revert changes to extract title from styles.blocks.variations #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @aaronrobertshaw for awareness (nothing to do). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR reverts #405
Why
#405 introduced the ability to extract strings (
title) from the propertystyles.blocks.variationsof thetheme.json— these were missing and detected during the beta period.Later on, the feature received more feedback and the consensus was to remove the ability to register block style variations from
theme.json. That together with some changes to the shape of thestylessubtree, made #405 unnecessary, as there is no longer atitlekey to translate.How
Revert the changes introduced in #405
Test
Automated test should pass. They are now broken in
main. See setup instructions at #405