Skip to content

Conversation

@swissspidy
Copy link
Member

Fixes #376

@swissspidy swissspidy added this to the 2.5.1 milestone Dec 18, 2023
@swissspidy swissspidy requested a review from a team as a code owner December 18, 2023 08:40
@swissspidy
Copy link
Member Author

FYI @ocean90 — would like to know if you think this makes sense or not.

Copy link
Contributor

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would be nice to have the line numbers as well but not a blocker for me.

@swissspidy
Copy link
Member Author

swissspidy commented Dec 18, 2023

Yeah I thought about that as well. Always thought that requires a more complex solution (see #65) but maybe using PREG_OFFSET_CAPTURE would suffice (see this SO post). I'll see how feasible it is and otherwise will file a follow-up issue.

Edit: simply reopened and repurposed #65

@swissspidy
Copy link
Member Author

@wp-cli/committers would appreciate a quick review here so I can merge this

@swissspidy swissspidy enabled auto-merge January 16, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding file reference for strings extracted from file headers

4 participants