Skip to content

Improve warning message for install and activate multiple themes #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2024
Merged

Improve warning message for install and activate multiple themes #419

merged 2 commits into from
Apr 26, 2024

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Apr 26, 2024

Improves the warning message present when wp theme install --activate is used with multiple themes:

Before:

$ wp theme install twentytwelve twentyeleven --activate
Warning: Only a single theme can be active.

After:

$ wp theme install twentytwelve twentyeleven --activate
Warning: Only this single theme will be activated: twentyeleven

From #408
Related #406
Related wp-cli/wp-cli#5935

@danielbachhuber danielbachhuber added this to the 2.1.20 milestone Apr 26, 2024
@danielbachhuber danielbachhuber self-assigned this Apr 26, 2024
@danielbachhuber danielbachhuber requested a review from a team as a code owner April 26, 2024 10:27
@danielbachhuber danielbachhuber mentioned this pull request Apr 26, 2024
Merged
@ernilambar ernilambar merged commit 5dcbb5e into main Apr 26, 2024
@ernilambar ernilambar deleted the improve-multiple-theme-install-warning branch April 26, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@danielbachhuber danielbachhuber

Labels

command:theme command:theme-install

Projects

None yet

Milestone

2.1.20

Development

Successfully merging this pull request may close these issues.

4 participants

@danielbachhuber @swissspidy @ernilambar