Skip to content

Warn on delete failure, instead of hard exiting #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2023
Merged

Warn on delete failure, instead of hard exiting #376

merged 3 commits into from
Oct 11, 2023

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Oct 11, 2023

Fixes #238

Previous behavior:

$ chmod 555 wp-content/plugins/akismet
$ wp plugin delete akismet
$ echo $?
1

New behavior:

$ chmod 555 wp-content/plugins/akismet
$ wp plugin delete akismet
Warning: The 'akismet' plugin could not be deleted.
Error: No plugins deleted.

@danielbachhuber danielbachhuber added this to the 2.1.15 milestone Oct 11, 2023
@danielbachhuber danielbachhuber self-assigned this Oct 11, 2023
@danielbachhuber danielbachhuber requested a review from a team as a code owner October 11, 2023 11:39
@danielbachhuber danielbachhuber mentioned this pull request Oct 11, 2023
Closed
swissspidy
swissspidy reviewed Oct 11, 2023
View reviewed changes
@danielbachhuber @swissspidy
Newline at the end of the file
404d166 
Co-authored-by: Pascal Birchler <pascalb@google.com>
@danielbachhuber danielbachhuber merged commit 1fe271c into main Oct 11, 2023
@danielbachhuber danielbachhuber deleted the improve/warning-delete-failure branch October 11, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@danielbachhuber danielbachhuber

Labels

bug command:plugin command:plugin-delete

Projects

None yet

Milestone

2.1.15

Development

Successfully merging this pull request may close these issues.

plugin delete hangs when file permissions forbid the operation

3 participants

@danielbachhuber @swissspidy