-
Notifications
You must be signed in to change notification settings - Fork 87
Replace one-time-login with a sample plugin in the tests #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@schlessera Should this sample plugin live in the wp-cli org so that we can guarantee it exists? In case https://github.com/Nikschavan/test-wordpress-plugin ever gets deleted :-) |
|
I was hoping it would be simpler to fork and get this into wp-cli org? I mentioned in the issue #301 it would be preferable to be in this org. Maybe anyone with capabilities can create a repo here instead and I can use that links in this PR? |
|
We have https://github.com/wp-cli-test/generic-example-plugin or AFAIK we can transfer @Nikschavan to |
|
Ahh, I didn't knew about the generic-example-plugin. That should work for this use case as well. I will use that one instead of creating a new one. Thanks @wojsmol :) |
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
|
I will need one more help from folks who have access to the repo https://github.com/wp-cli-test/generic-example-plugin. One of the tests will require a release to be created for the plugin generic-exaple-plugin and a ZIP file to be uploaded to the release, Same as the release on one-time-login plugin - https://github.com/danielbachhuber/one-time-login/releases/tag/v0.1.2 |
|
That'd have to be @schlessera in that case |
|
@Nikschavan This is done, the repo now has two published releases, each with a separate ZIP as attached asset. |
Co-authored-by: Wojciech Smoliński <wojsmol@wp.pl>
Fixes #301
Replaces the plugin one-time-login with a sample WordPress plugin