This repository was archived by the owner on Jan 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
Museum victoria #447
Merged
Merged
Museum victoria #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into museum_victoria
…into museum_victoria
mathemancer
suggested changes
Jul 10, 2020
Contributor
mathemancer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks ready to ship once the unused import is removed.
src/cc_catalog_airflow/dags/provider_api_scripts/museum_victoria.py
Outdated
Show resolved
Hide resolved
…into museum_victoria
mathemancer
approved these changes
Jul 10, 2020
Contributor
mathemancer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #291 by @akshgpt7
Description
Museum victoria provider has been implemented .
Technical details
The image id represents the new image id field --
media/329745Checklist
Update index.md).masterbranch of the repository.visible errors.
Developer Certificate of Origin
Developer Certificate of Origin