Skip to content

Conversation

@dd32
Copy link
Member

@dd32 dd32 commented May 12, 2025

#687 added the Mastodon account to get it verified, but we have a lot more accounts on every other platform that has been asked to be listed.

@eidolonnight @bjmcsherry have asked to increase this to all of the accounts.

These include:
X
Bluesky
Mastodon
Threads
Facebook
Instagram
Linkedin
TikTok
YouTube
Tumblr

The proposed layout would be:

X | Bluesky | Mastodon | Threads | Facebook | Instagram | LinkedIn | TikTok | YouTube | Tumblr

The visual representation of these gets a bit busy, but not overly bad in my opinion.
There's some responsive work that could/should be done here, although this pre-dates this change, this just makes it a little more obvious.

Screenshot 2025-05-12 at 12 24 59 pm
Screenshot 2025-05-12 at 12 26 00 pmScreenshot 2025-05-12 at 12 26 18 pm
Screenshot 2025-05-12 at 12 26 18 pmScreenshot 2025-05-12 at 12 26 44 pm

@dd32 dd32 requested a review from eidolonnight May 12, 2025 02:33
@eidolonnight
Copy link

There's some responsive work that could/should be done here, although this pre-dates this change, this just makes it a little more obvious.

Can this be addressed prior to commit? Some of these layouts are pretty messy.

If not, do we need to select a subset of platforms for now?

Copy link

@eidolonnight eidolonnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links are all correct, and any alignment issues do not represent a regression from current behavior.

@ryelle
Copy link
Contributor

ryelle commented May 14, 2025

I happened to see this and took a stab at fixing up the alignments. It's still a little odd when just one or two items wrap, but overall better spacing & alignment across screen sizes.

Size Main Rosetta
450px after-en-450 after-es-450
600px after-en-600 after-es-600
960px after-en-960 after-es-960
1600px after-en-1600 after-es-1600

@dd32
Copy link
Member Author

dd32 commented May 15, 2025

Thank you @ryelle! You're so much better at these styles than I am! I hadn't yet attempted it, but I'm almost certain it wouldn't have looked that good without you

I had wondered if we should drop the mobile-only (w) and use the full (w) WordPress.org always such that the 450px/600px viewports are more visually balanced, so that it doesn't look like the plain WordPress logo is misaligned with the social icons.. since currently it blends in and looks like one of them.

And yes, I agree, it's a little odd looking when only some icons wrap, I was originally going to see if there was a flexbox text-wrap: balance that would work here, but I imagine not.

@ryelle
Copy link
Contributor

ryelle commented May 15, 2025

since currently it blends in and looks like one of them.

Yeah, I ended up adding a larger space between so it doesn't get close enough to look like yet another social icon. The 600px screenshot is about as close as they'll get, I think.

And yes, I agree, it's a little odd looking when only some icons wrap, I was originally going to see if there was a flexbox text-wrap: balance that would work here, but I imagine not.

I was hoping the same, but that's not how flex works unfortunately. Maybe switching to a float layout would let us use balance, but I'm not actually sure. And I don't think we want to deal with floats.

@dd32 dd32 merged commit 61aee1f into trunk May 15, 2025
2 checks passed
@dd32 dd32 deleted the add/all-the-socials branch May 15, 2025 02:32
@zokhshop11

This comment was marked as spam.

@zokhshop11

This comment was marked as spam.

@zokhshop11

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants