Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

Motivation for the change, related issues

Addresses review feedback from #2961 to split OPFS tests into a separate file to avoid an artificially large test group.

Implementation details

  • Created opfs.spec.ts with all 9 OPFS-related tests (those checking browserName !== 'chromium')
  • Moved saveSiteViaModal helper to the new file
  • Kept serial execution mode in opfs.spec.ts since OPFS storage is shared at browser level
  • Removed serial mode from website-ui.spec.ts as remaining tests don't require it

Testing Instructions (or ideally a Blueprint)

Run the E2E tests to verify both test files execute correctly:

npx playwright test packages/playground/website/playwright/e2e/opfs.spec.ts
npx playwright test packages/playground/website/playwright/e2e/website-ui.spec.ts

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: adamziel <205419+adamziel@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
    • Triggering command: /usr/local/bin/node node index.js --exec install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Split OPFS tests into separate files Split OPFS tests into separate file Nov 28, 2025
Copilot AI requested a review from adamziel November 28, 2025 19:06
Copilot finished work on behalf of adamziel November 28, 2025 19:06
@adamziel adamziel marked this pull request as ready for review November 28, 2025 22:19
@adamziel adamziel merged commit 2420e0c into speedup-e2e-tests Nov 28, 2025
63 of 64 checks passed
@adamziel adamziel deleted the copilot/sub-pr-2961 branch November 28, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants