Skip to content

Conversation

@adamziel
Copy link
Collaborator

@adamziel adamziel commented Nov 22, 2025

Motivation for the change, related issues

Cleans up resources in two, notoriously flaky unit tests to make them more reliable:

  • Cleans up resources, calls php.exit()
  • Stops the server to free up the port
  • Updates the Xdebug DBGP integration test to use an ephemeral port
  • Adds a handshake timeout and improved error handling for the DBGP server
  • Ensures the tests fails gracefully when the handshake is not completed in time.

The tests we're trying to fix:

  ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯
  
   FAIL  src/test/php-dynamic-loading.spec.ts > PHP 8.0 > XDebug > communicates with default DBGP port
   FAIL  src/test/php-networking.spec.ts > PHP 8.0 > cURL > should support multi handle requests
  Error: Test timed out in 20000ms.

Testing Instructions (or ideally a Blueprint)

CI :)

@adamziel adamziel added the [Type] Enhancement New feature or request label Nov 25, 2025
@adamziel adamziel marked this pull request as ready for review November 25, 2025 13:01
@adamziel adamziel merged commit 3da2989 into trunk Nov 25, 2025
31 of 32 checks passed
@adamziel adamziel deleted the fix-flaky-curl-dbgp-tests branch November 25, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants