HTML API: Reliably parse HTML in get_url_in_content()
#9272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60cf2c3 to
51c23b6
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
51c23b6 to
5bb26b8
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
approved these changes
Jul 16, 2025
Member
sirreal
left a comment
There was a problem hiding this comment.
This seems like a clear improvement and has basic test coverage.
12 tasks
f4ecd29 to
81dd3d4
Compare
Trac ticket: Core-63694 This also decodes the URL whereas the previous code didn’t, so strings like `http://` will be properly decoded as `http://`.
81dd3d4 to
71b86cf
Compare
pento
pushed a commit
that referenced
this pull request
Aug 26, 2025
As part of a larger effort in #63694, this utlizes `WP_HTML_Tag_Processor` instead of regex to parse the string passed into `get_url_in_content`. As a benefit this also decodes the URL whereas the previous code didn’t, so strings like `http://` will be properly decoded as `http://`. Developed in: #9272 Discussed in: https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell, nerrad. Fixes #63694. git-svn-id: https://develop.svn.wordpress.org/trunk@60665 602fd350-edb4-49c9-b593-d223f7449a82
Member
Author
|
Merged in [60665] |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 26, 2025
As part of a larger effort in #63694, this utlizes `WP_HTML_Tag_Processor` instead of regex to parse the string passed into `get_url_in_content`. As a benefit this also decodes the URL whereas the previous code didn’t, so strings like `http://` will be properly decoded as `http://`. Developed in: WordPress/wordpress-develop#9272 Discussed in: https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell, nerrad. Fixes #63694. Built from https://develop.svn.wordpress.org/trunk@60665 git-svn-id: http://core.svn.wordpress.org/trunk@60001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
CallumBW95
pushed a commit
to CallumBW95/wordpress-develop
that referenced
this pull request
Aug 26, 2025
As part of a larger effort in #63694, this utlizes `WP_HTML_Tag_Processor` instead of regex to parse the string passed into `get_url_in_content`. As a benefit this also decodes the URL whereas the previous code didn’t, so strings like `http://` will be properly decoded as `http://`. Developed in: WordPress#9272 Discussed in: https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell, nerrad. Fixes #63694. git-svn-id: https://develop.svn.wordpress.org/trunk@60665 602fd350-edb4-49c9-b593-d223f7449a82
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Aug 26, 2025
As part of a larger effort in #63694, this utlizes `WP_HTML_Tag_Processor` instead of regex to parse the string passed into `get_url_in_content`. As a benefit this also decodes the URL whereas the previous code didn’t, so strings like `http://` will be properly decoded as `http://`. Developed in: WordPress/wordpress-develop#9272 Discussed in: https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell, nerrad. Fixes #63694. Built from https://develop.svn.wordpress.org/trunk@60665 git-svn-id: https://core.svn.wordpress.org/trunk@60001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
jonnynews
pushed a commit
to spacedmonkey/wordpress-develop
that referenced
this pull request
Sep 24, 2025
As part of a larger effort in #63694, this utlizes `WP_HTML_Tag_Processor` instead of regex to parse the string passed into `get_url_in_content`. As a benefit this also decodes the URL whereas the previous code didn’t, so strings like `http://` will be properly decoded as `http://`. Developed in: WordPress#9272 Discussed in: https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell, nerrad. Fixes #63694. git-svn-id: https://develop.svn.wordpress.org/trunk@60665 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-63694
This also decodes the URL whereas the previous code didn’t, so strings like
http://will be properly decoded ashttp://.