Skip to content

Conversation

@PARTHVATALIYA
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/60969

Add error message to URL input field under the add custom link section.
Add CSS to the error message.

@github-actions
Copy link

github-actions bot commented Feb 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props parthvataliya, joedolson.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Feb 7, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson joedolson self-requested a review February 7, 2025 17:41
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some misc. code style issues in the JS, mostly surrounding use of spaces - in general the content inside parentheses should have spaces, e.g. $( '#submit-customlinkdiv' ).

But this is generally good; just needs some minor polish.

@PARTHVATALIYA
Copy link
Author

@joedolson I made the changes you suggested can you please review it.

Thank You!

1) Spacing; 2) Remove aria-invalid and aria-describedby when other invalid classes and errors removed. 3) Get error message from content rather than duplicating the message.
@joedolson joedolson dismissed their stale review March 4, 2025 23:48

Outdated; completed but not yet approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants