Skip to content

Conversation

@snehapatil2001
Copy link

Ticket: https://core.trac.wordpress.org/ticket/59945

  • This PR addresses an issue in the add_feed function where feed names starting with an underscore are not handled properly, leading to errors.
  • The function now includes validation to prevent feed names from starting with an underscore, improving overall robustness and developer experience.

Background:

  • The add_feed function allows developers to register custom feed types in WordPress. However, if the feed name starts with an underscore, it is stripped by the do_feed function, causing unexpected errors.
  • This PR introduces a validation step to ensure feed names do not start with an underscore, thereby avoiding these issues.

Changes Made:

Validation in add_feed Function:

  • Added a check to ensure the feed name does not start with an underscore (_).
  • If the feed name is invalid, an error is logged using error_log, and the function returns false.

Proper Initialization Check:

  • Ensured that the $wp_rewrite global variable is initialized before proceeding with feed registration.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props snehapatil02.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant