Text correction on wordcamp Incident Report form

[harshgajipara]

Describe the bug
In the Incident Report form "Yes" text is not visible. (https://central.wordcamp.org/incident-report/).

Steps to reproduce the behavior:

• go to https://central.wordcamp.org/incident-report/
• go to Was a police report filed field
• you will able to see the issue

Expected behavior

• it should be visible properly & easy to read.

Screenshots

Solution:

Just need to replace "legend" tag with "label"

[dd32]

This HTML is generated by the Jetpack Contact form module.

The relevant shortcode is this:

[contact-field label="Was a police report filed?" type="radio" options="Yes,No"]

It looks like this changed the HTML markup intentionally:
Automattic/jetpack#34147

Unfortunately, the twentyten theme styles legends differently than labels, and I'm not sure Jetpack should expect otherwise.

[dd32]

Additionally the above PR added an extra fieldset, so now it's fieldset > fieldset which results in the double padding and margins.

The fix required here is going to be a bunch of CSS styles that override twentytens styles, and/or a jetpack bug report to revert/change the behaviour.

[sabernhardt]

I did not find a problem with the Jetpack form in my own WordPress installation, so Automattic/jetpack#34147 seems to have fixed the Jetpack plugin. In my test, the group has one fieldset with a visible legend as its first child element, and each option has a visible label programmatically connected to its button.

However, the WordCamp site has temporary tweaks from #874 that probably do not belong there anymore.

wordcamp.org/public_html/wp-content/mu-plugins/jetpack-tweaks/miscellaneous.php

Lines 199 to 206 in 7823c7a

	* Upstream issue: https://github.com/Automattic/jetpack/issues/16685.
	* When that is fixed, this & `inject_css_for_fieldset` can be removed.
	*
	* @param string $rendered_field Contact Form HTML output.
	* @param string $field_label Field label.
	* @param int|null $post_id Post ID.
	*/
	function wrap_checkbox_radio_fieldset( $rendered_field, $field_label, $post_id ) {

The first item ("Yes") needs to be a label for the radio button, and the screen-reader-only styles for legend elements are not appropriate on the Incident Report page (any other forms likely should not hide the legend either).