Test Core Ticket with Playground: Fix images alignment issue #79
Conversation
There was a problem hiding this comment.
I tested this using the browser developer tools, and the responsiveness has improved significantly. The image URL is correct, and everything works great. This pull request is perfect and ready to be merged. @SirLouen
Test.Core.Tickets.with.Playground.Make.WordPress.Test.-.Google.Chrome.2025-10-31.10-35-51.mp4
|
I have tested it with inspector tools by adding that css. its looks good on desktop & responsive version as LGTM! cc @SirLouen |
There was a problem hiding this comment.
@nikunj8866 I'm not sure about this. We should be using markdown the maximum possible.
There is no specification though, when we deal with images sizes
Here we only have two options:
- Resize and reupload the images, ordely to the
assetsfolder and link to them (as we did with the buttons for the Badges section) - Use HTML as you did (do we really need the
heightattribute, by the way?
If we are going to consider HTML (as we did with the tooltips), I would consider two additional things
- Suggesting an improvement in the parser: I've already opened a ticket Automattic/jetpack#45734
- Adding the link to the image itself (in mobile, the images are very little, impossible to be read).
- Removing the
max-height(unnecessary, I believe). I'm not even sure if theobject-fitis necessary in this case
|
@SirLouen I've checked in the Hosting Handbook, and they’re using the same approach for images. You can see the code example here: https://github.com/WordPress/hosting-handbook/blob/main/performance.md?plain=1 |
I've been checking the markdown plugin, and the likelihood that they update it to support a full markdown conversion is 99.99% unlikely. They got stuck into an ancient version of 2013, which supports MD barebones, so we are condemned to simply use HTML combined with MD for long. Still, you can refine the HTML a little, as I commented to you above, given that we are going to take the HTML route. |
Fixing: #78