Allow config errors to be display to users

[pkevan]

Shows errors when user is logged in, and has appropriate capabilities.

Fixes #85.

Testing instructions

1. Add field to new install of SCF
2. Use shortcode [acf] to output field via [acf field=""]
3. Observe that with an administrator role, no output is display
4. Apply this PR
5. Re-test output, and a display error should be displayed in place of the field output
6. Check while logged out that no output is display as was show when logged in as administrator

Note: considered adding this to (

secure-custom-fields/includes/api/api-template.php

Line 1053 in a1257ed

if ( is_preview() ) {

), but given the additional filter, it didn't seem appropriate, although happy to be convinced otherwise.

[priethor]

Hi Paul! Can you share brief instructions in the PR description to test the PR?

[pkevan]

Hi Paul! Can you share brief instructions in the PR description to test the PR?

Most of the details are in the original issue: #85 (comment) but can adjust the PR if needed a bit later.

[priethor]

I would suggest adding, in general, a short section with steps to test it and the expected outcome with and without the PR, similar to Gutenberg PRs. Even though the original ticket wasn't too hard to follow, it still required me to read all the comments to get the context 😅

[pkevan]

I would suggest adding, in general, a short section with steps to test it and the expected outcome with and without the PR, similar to Gutenberg PRs. Even though the original ticket wasn't too hard to follow, it still required me to read all the comments to get the context 😅

Added in test instruction.

[priethor]

For documentation purposes, note that I had to do some (obvious) extra steps:

• Enable shortcodes programmatically.
• The Field Group is assigned to posts

With this branch, the error message appears indeed. However, I also see it when using the shortcode to display a Text Field, which, in theory, is supported by the shortcode. Am I missing something?

[pkevan]

However, I also see it when using the shortcode to display a Text Field, which, in theory, is supported by the shortcode. Am I missing something?

🤔 presumably this works as expected without the patch?

[pkevan]

However, I also see it when using the shortcode to display a Text Field, which, in theory, is supported by the shortcode.

In order to not see the message, the field needs to be enabled via the Editor UI radio:

Or were you trying another way?

[pkevan]

I wonder how much value there would be in enabling the shortcode via a setting, rather than requiring some code to be added?

[priethor]

Sorry for the late reply, my issue was related to the Allow Access to Value in Editor UI as I was seeing a different kind of error message:

• With this PR:
  • Disabling the checkbox shows the message [The requested ACF field is not allowed to be output in bindings or the ACF Shortcode.] message from the preview, or if the user has enough permissions (not for unlogged users).
  • Enabling the checkbox hides the message.
• Without this PR:
  • The message doesn't show regardless of the checkbox status or the user.