Migrate custom phpcs sniffs to WordPress coding standards

[kkmuffme]

Since there are already official WordPress coding standards https://github.com/WordPress/WordPress-Coding-Standards, I think there shouldn't be another place with sniffs?
The custom "PluginCheck" sniffs should be migrated to the existing coding standards, as well as the ruleset.

If for whatever reason that isn't possible, the custom plugin checks should at least be published as a standalone rulesets (one that includes all, and only sniffs created by this plugin), so it can be used standalone too.

[swissspidy]

The WPCS project is specifically for adhering to WordPress Coding Standards, whereas the sniffs in this repo are for adhering to plugin directory guidelines, so two completely different things.

[ernilambar]

Rather than including in WPCS, I am thinking about making our custom sniff publicly accessible. Or there could be some way which is already possible. No idea.

Ref: https://github.com/WordPress/plugin-check/tree/trunk/phpcs-sniffs

[kkmuffme]

Rather than including in WPCS, I am thinking about making our custom sniff publicly accessible

yeah that would basically be #966 then, which I think is definitely a good idea

The WPCS project is specifically for adhering to WordPress Coding Standards, whereas the sniffs in this repo are for adhering to plugin directory guidelines, so two completely different things.

In fact the WPCS project has a WordPress-Extra coding standard, which goes beyond WordPress' Coding Standards. Therefore, moving this plugin's phpcs rules to WPCS and naming it WordPress-Plugins would streamline general accessibility, long term availability and maintenance of these standards.

[ernilambar]

Ok. Closing this now.