Allow specifying optional provider credentials URL in provider metadata #135
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| * @param string|null $credentialsUrl The URL where users can get credentials. | ||
| */ | ||
| public function __construct(string $id, string $name, ProviderTypeEnum $type) | ||
| public function __construct(string $id, string $name, ProviderTypeEnum $type, ?string $credentialsUrl = null) |
There was a problem hiding this comment.
Now that this is four parameters long and we're starting to get into optional parameters, I'm curious if we should consider either an array as an optional fourth argument that can extend over time to include more, or if we should instead add a setter for things like this.
Another option is to stick with this for now and then change it to an array later if/when the time arrives and make this parameter backwards-compatible.
What do you think, @felixarntz?
There was a problem hiding this comment.
I'd say let's do the latter. It'll be easy to keep things backward compatible in the way you're saying.
Fixes #129