Skip to content

Add standalone plugin version constants for auto-sizes and speculation-rules #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

Add standalone plugin version constants for auto-sizes and speculation-rules #958

merged 1 commit into from
Jan 29, 2024

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Jan 29, 2024

Summary

Add slugs/constants to perflab_get_standalone_plugin_version_constants() so that the Auto-sizes for Lazy-loaded Images and Speculation Rules plugins will be recommended once 2.9.0 is released.

Before After
image image

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@westonruter westonruter added [Type] Feature A new feature within an existing module Infrastructure Issues for the overall performance plugin infrastructure labels Jan 29, 2024
@westonruter westonruter added this to the PL Plugin 2.9.0 milestone Jan 29, 2024
adamsilverstein
adamsilverstein approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@swissspidy swissspidy merged commit 4396a84 into trunk Jan 29, 2024
@swissspidy swissspidy deleted the add/standalone-plugin-version-constants branch January 29, 2024 23:28
@westonruter westonruter mentioned this pull request Feb 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Feature A new feature within an existing module

Projects

None yet

Milestone

PL Plugin 2.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@westonruter @swissspidy @adamsilverstein