Skip to content

Fix errors detected by Plugin Checker #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix errors detected by Plugin Checker #788

merged 1 commit into from
Jul 21, 2023

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jul 21, 2023 •
edited
Loading

Summary

Fixes #787

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Jul 21, 2023
@mukeshpanchal27 mukeshpanchal27 added this to the PL Plugin 2.6.0 milestone Jul 21, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Jul 21, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 21, 2023 08:42
@felixarntz felixarntz changed the title Fix Errors Detected by Plugin Checker Fix errors detected by Plugin Checker Jul 21, 2023
felixarntz
felixarntz approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

@felixarntz felixarntz merged commit b7365ec into trunk Jul 21, 2023
@felixarntz felixarntz deleted the fix/787-phpcs-issues branch July 21, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@felixarntz felixarntz felixarntz approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@swissspidy swissspidy Awaiting requested review from swissspidy

@10upsimon 10upsimon Awaiting requested review from 10upsimon

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Bug An existing feature is broken

Projects

None yet

Milestone

PL Plugin 2.6.0

Development

Successfully merging this pull request may close these issues.

Errors in Performance Lab Plugin Detected by Plugin Checker

4 participants

@mukeshpanchal27 @westonruter @felixarntz