Skip to content

Fix incorrect usage of plugin_action_links_* filter #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fix incorrect usage of plugin_action_links_* filter #647

merged 1 commit into from
Feb 6, 2023

Conversation

@kt-12
Copy link
Member

@kt-12 kt-12 commented Feb 6, 2023 •
edited by felixarntz
Loading

Summary

Fixes #646

Changed
add_action to add_filter

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@kt-12 kt-12 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Feb 6, 2023
mukeshpanchal27
mukeshpanchal27 approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kt-12, Great catch. The changes LGTM!

@mukeshpanchal27 mukeshpanchal27 added this to the 2.0.0 milestone Feb 6, 2023
@mukeshpanchal27 mukeshpanchal27 removed the no milestone PRs that do not have a defined milestone for release label Feb 6, 2023
@mukeshpanchal27 mukeshpanchal27 merged commit 2ebe0b7 into trunk Feb 6, 2023
@mukeshpanchal27 mukeshpanchal27 deleted the bug/plugin_action_links_fix branch February 6, 2023 10:16
@felixarntz felixarntz changed the title Fixes plugin_action_links_ filter Fix incorrect usage of plugin_action_links_* filter Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjgrainger jjgrainger jjgrainger approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Improper usage of add_action to update plugin action links

4 participants

@kt-12 @jjgrainger @mukeshpanchal27