Skip to content

Avoid unnecessarily early escape of Site Health check labels #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2022
Merged

Avoid unnecessarily early escape of Site Health check labels #332

merged 3 commits into from
May 10, 2022

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented May 10, 2022 •
edited by felixarntz
Loading

As suggested by @felixarntz in the #329 ticket.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz changed the title Correct escaping function Avoid unnecessarily early escape of Site Health check labels May 10, 2022
felixarntz
felixarntz approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @mukeshpanchal27!

@felixarntz felixarntz requested a review from tillkruss May 10, 2022 17:52
@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels May 10, 2022
@felixarntz felixarntz added this to the 1.1.0 milestone May 10, 2022
@felixarntz felixarntz changed the base branch from trunk to release/1.1.0 May 10, 2022 19:52
@felixarntz
Copy link
Member

felixarntz commented May 10, 2022

@mukeshpanchal27 I've updated the base branch to release/1.1.0, with the goal to get this into the upcoming release.

Can someone else please approve this by tomorrow? cc @adamsilverstein @manuelRod @kirtangajjar @mitogh @tillkruss 🙌

@felixarntz felixarntz merged commit 6e72e47 into WordPress:release/1.1.0 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixarntz felixarntz felixarntz approved these changes

@mitogh mitogh mitogh approved these changes

@manuelRod manuelRod Awaiting requested review from manuelRod manuelRod is a code owner

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@kirtangajjar kirtangajjar Awaiting requested review from kirtangajjar kirtangajjar is a code owner

@tillkruss tillkruss Awaiting requested review from tillkruss

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mukeshpanchal27 @felixarntz @mitogh