-
Notifications
You must be signed in to change notification settings - Fork 140
Add No-cache BFCache to list of performance feature plugins #2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #2119 +/- ##
==========================================
+ Coverage 67.58% 67.60% +0.01%
==========================================
Files 93 93
Lines 7799 7803 +4
==========================================
+ Hits 5271 5275 +4
Misses 2528 2528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
swissspidy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
This proposes adding No-cache BFCache to the list of performance feature plugins installable via Performance Lab, similar as the non-monorepo Performant Translations plugin is made available:
I brought this up at our last Performance Chat office hours:
Enabling bfcache in core is something I'm hoping to include in 6.9 (via Core-63636), so getting additional installations via Performance Lab will be very helpful to get more testing.
With #2122, an admin pointer is also added for this feature: