Skip to content

Add link to Settings screen to the plugin's entry in plugins list table #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2022
Merged

Add link to Settings screen to the plugin's entry in plugins list table #197

merged 2 commits into from
Mar 2, 2022

Conversation

@felixarntz
Copy link
Member

@felixarntz felixarntz commented Feb 28, 2022

Summary

Fixes #192

Relevant technical choices

  • Add link to Settings / module screen if it is available.
  • To do that reliably, the new action is only added if the screen was added successfully.

Screenshot:
Screen Shot 2022-02-28 at 2 31 53 PM

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure Needs Review labels Feb 28, 2022
@felixarntz felixarntz added this to the 1.0.0-beta.1 milestone Feb 28, 2022
@felixarntz felixarntz merged commit 638108e into trunk Mar 2, 2022
@tillkruss tillkruss deleted the add/plugin-action-link branch March 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tillkruss tillkruss tillkruss approved these changes

@mitogh mitogh mitogh approved these changes

@JustinyAhin JustinyAhin JustinyAhin approved these changes

@dainemawer dainemawer dainemawer approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

1.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Provide link to the plugin's admin screen in plugins list table

8 participants

@felixarntz @tillkruss @mitogh @kt-12 @JustinyAhin @dainemawer @eclarke1