-
Notifications
You must be signed in to change notification settings - Fork 140
Replace the full size image in the_content with additional MIME type if available
#195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mage-size-in-content
If the full size image is present as part of the metadata information, make sure the image is replaced in the content with the new reference to the expected image. This fixes #174
the_content with the full size image in new mime types if available
…e-size-in-content
…e-size-in-content
adamsilverstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
felixarntz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitogh The new code overall looks solid, I found a few small issues that mostly relate to the already existing code, but we had missed them before.
…e-size-in-content
Prevent from running a loop when is not required
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
felixarntz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Ah nevermind the above, I see you've created this against your branch for #194. I think for the future it would be better to create both PRs based on So I'd still say it's better to wait until #194 has been approved before we merge this. |
|
Thanks, mostly I've created this based on #194 just to have smaller diffs I agree this should is currently being blocked by #194 but having everything based on |
the_content with the full size image in new mime types if availablethe_content with additional MIME type if available
Summary
Fixes #174
This PR requires:
the_contentwith the appropiate image format #152Relevant technical choices
This PR updates the changes introduced by #152 and #194 in order to replace the
fullsize image if present in the new format, (in this case WebP) making sure all images served to the client are in the same format when a new image is uploaded into WordPress.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.