Skip to content

Conversation

@mrmakadia94
Copy link
Contributor

Summary

Fixes #

Relevant technical choices

  • use unslashed and sanitization for $_GET['file']
  • use $plugin_data['requires'] ?? null to reduce cognitive load.

@github-actions
Copy link

github-actions bot commented Apr 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mrmakadia94 <immeet94@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @mrmakadia94. The changes you proposed seem redundant. Please review my feedback.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release labels Apr 22, 2024
@mukeshpanchal27 mukeshpanchal27 added the Good First Issue Issue particularly suitable to be worked on by new contributors label Apr 23, 2024
@westonruter westonruter added this to the performance-lab 3.1.0 milestone Apr 23, 2024
@westonruter westonruter added skip changelog PRs that should not be mentioned in changelogs and removed no milestone PRs that do not have a defined milestone for release labels Apr 23, 2024
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mukeshpanchal27 mukeshpanchal27 merged commit a455dd5 into WordPress:trunk Apr 24, 2024
@mrmakadia94 mrmakadia94 deleted the enhance/wpcs branch April 24, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First Issue Issue particularly suitable to be worked on by new contributors skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants