Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

What?

Remove the re-registration check from the private APIs package. This allows packages to opt-in to private APIs multiple times.

Why?

Some packages like data views and global styles UI are bundled in other packages multiple times, causing the private APIs registration to fail with duplicate opt-in errors—except in Gutenberg itself. This behavior difference between Gutenberg and Core is preventing package syncs because editors crash.

The explicit opt-in process (install package, consent string, unlock) already communicates that these APIs are private with no backwards compatibility guarantees. The check was being worked around via npm patches anyway.

How?

  • Removed the registeredModules Set and duplicate registration check from implementation.ts
  • Removed the now-failing unit test "Should not register the same module twice"

Testing Instructions

Tests should pass.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Nov 27, 2025
Co-authored-by: ellatrix <4710635+ellatrix@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 27, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • translate.wordpress.org
    • Triggering command: /usr/local/bin/node node i18n-cache/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Remove re-registration check from private APIs Private APIs: remove re-registration check Nov 27, 2025
Copilot AI requested a review from ellatrix November 27, 2025 10:43
Copilot finished work on behalf of ellatrix November 27, 2025 10:43
@ellatrix ellatrix marked this pull request as ready for review November 27, 2025 11:35
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Copilot.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@ellatrix ellatrix merged commit f4bb8ed into remove/allow-re-registration Nov 27, 2025
1 of 2 checks passed
@ellatrix ellatrix deleted the copilot/sub-pr-73610 branch November 27, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants