Private APIs: remove re-registration check #73613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the re-registration check from the private APIs package. This allows packages to opt-in to private APIs multiple times.
Why?
Some packages like data views and global styles UI are bundled in other packages multiple times, causing the private APIs registration to fail with duplicate opt-in errors—except in Gutenberg itself. This behavior difference between Gutenberg and Core is preventing package syncs because editors crash.
The explicit opt-in process (install package, consent string, unlock) already communicates that these APIs are private with no backwards compatibility guarantees. The check was being worked around via npm patches anyway.
How?
registeredModulesSet and duplicate registration check fromimplementation.tsTesting Instructions
Tests should pass.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.