Template Activation: Use string IDs when experiment is off #73585
+121
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Nov 26, 2025
ellatrix
reviewed
Nov 26, 2025
Member
|
Hm, so this needs to be included in WP 6.9, no? |
Member
|
Adding it to the board just in case. |
ellatrix
reviewed
Nov 26, 2025
Member
|
Actually, I forgot that we did a full revert on the wp/6.9 branch 😅 |
ellatrix
reviewed
Nov 26, 2025
scruffian
reviewed
Nov 26, 2025
Member
Author
|
I've moved this new test to its own suite and made sure it's testing the correct flow (this error only happens if you edit a template via the "Edit template" link when editing a page). This should be ready for another review 🙇 |
ellatrix
reviewed
Nov 27, 2025
ellatrix
reviewed
Nov 27, 2025
scruffian
approved these changes
Nov 27, 2025
Contributor
scruffian
left a comment
There was a problem hiding this comment.
This is working for me. Good idea adding a test for too.
ellatrix
reviewed
Nov 27, 2025
ellatrix
reviewed
Nov 27, 2025
ellatrix
reviewed
Nov 27, 2025
ellatrix
reviewed
Nov 27, 2025
ellatrix
reviewed
Nov 27, 2025
ellatrix
approved these changes
Nov 27, 2025
|
Flaky tests detected in 0dbb7d6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19739128836
|
mikachan
added a commit
that referenced
this pull request
Nov 28, 2025
* Check for experiment before passing wp_id * Add tests to cover template ID format * Remove fallbacks * Fallback to id when experiment enabled * Move test to its own suite * Fix missing optional chaining * Update test * Include error message in test * Use correct page flow in test * Update comment * Reduce duplication * Fix test * Improve how dialogues are dismissed * Refactor tests * Split into two tests * Forcefully close welcome guide * Address nits * Use welcomeGuideTemplate Co-authored-by: mikachan <mikachan@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
Member
Author
|
I just cherry-picked this PR to the release/22.2 branch to get it included in the next release: 8a407e4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes a "No templates exist with that id." error when editing templates via a Page, i.e. clicking on "Edit template" in the block inspector, noticed in GB 22.1:
Why?
When the Template Activation experiment is disabled, we should pass the string ID format (theme//slug) rather than the numeric
wp_id.How?
Checks if the experiment is enabled before deciding to use the slug or ID. Also added some e2e tests to cover this scenario.
Testing Instructions