Try adding generic entity search component with combobox component #73469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8 kB (+0.32%) Total Size: 2.55 MB
ℹ️ View Unchanged
|
getdave
reviewed
Nov 21, 2025
| label="Select a post" | ||
| value={ url } | ||
| onChange={ setUrl } | ||
| suggestionsQuery={ { type: 'post', subtype: 'post' } } |
Contributor
There was a problem hiding this comment.
I always disliked this API. It's a configuration based approach that ends up leading to prop bloat.
I wonder if we could lean into allow the consumer to define their own fetching approach. Maybe that's passing in fetchLinkSuggestions or maybe that's passing in their own custom implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #71457 and #71452
What?
Closes #73310
Adds a generic entity search component using the
<ComboboxControl/>Why?
Add a link search to the inspector sidebar. I wanted to see how it might work using the combobox instead of extracting the link ui search. The LinkUI search is pretty bound to the popover, so I wanted to see how it might work.
How?
Create a new component called
<EntitySearch />and build out similar functionality to the LinkControl searchTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast