Real-time collaboration: Do not call saveRecord when persistence is not supported

[chriszarate]

What?

Prevent the sync manager from calling the saveRecord handler when CRDT persistence is not supported.

Why?

The only purpose of calling the saveRecord handler is to persist the CRDT document—either for the first time or after a previously persisted document is invalidated. Therefore, it should be called inside a check for syncConfig.supports.crdtPersistence.

For entities that should not or cannot be saved (such as the site settings entity), this bug resulted in a failing API request to save the entity (e.g., POST /wp-json/wp/v2/settings?_locale=user).

How?

1. Wrap the saveRecord call in a check.
2. Remove the redundant call to createEntityMeta. This was a bad merge artifact. Calling createEntityMeta is now handled in the entity's pre-persist hook.

Testing Instructions

1. Check out this branch.
2. Load a post for editing.
3. Make a change and click Save.
4. Ensure that there is no POST request to /wp-json/wp/v2/settings?_locale=user.

Testing Instructions for Keyboard

No UI changes in this PR.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>
Co-authored-by: pkevan <paulkevan@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[pkevan]

Tested, and solves the issue.