Skip to content

Fix: Custom font size taking over fit text. #73241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2025
Merged

Fix: Custom font size taking over fit text. #73241

merged 4 commits into from
Nov 13, 2025

Conversation

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Nov 13, 2025

Fixes: #73211

Fixes an issue where if a paragraph/heading had a custom font size and then was conververted to the stretchy variation. The custom font size on the front end was applied instead of fit text.

cc: @mrwweb

How?

Insert Paragraph block
Type some text in it
Set a non-default font size for the Paragraph block
Switch the Paragraph to the fit text Paragraph variation
The front-end of the site should not use the font size setting selected in Step 3 and should instead show fit text working normally as in the editor.

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Block] Stretchy Text labels Nov 13, 2025
@jorgefilipecosta jorgefilipecosta mentioned this pull request Nov 13, 2025
Closed
6 tasks
jorgefilipecosta
jorgefilipecosta commented Nov 13, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 13, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: mrwweb <mrwweb@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

jorgefilipecosta and others added 2 commits November 13, 2025 16:30
@jorgefilipecosta @mcsf
Update lib/block-supports/typography.php
2aa462a 
Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com>
@jorgefilipecosta
Improve fit text condition
9c8c2fa
mcsf
mcsf approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the missing core backport is attached

@jorgefilipecosta jorgefilipecosta mentioned this pull request Nov 13, 2025
Closed
@jorgefilipecosta jorgefilipecosta merged commit caeea80 into trunk Nov 13, 2025
34 checks passed
@jorgefilipecosta jorgefilipecosta deleted the fix/fit-text-font-size-issue-on-transform branch November 13, 2025 22:05
@github-actions github-actions bot mentioned this pull request Nov 13, 2025
Open
@github-actions github-actions bot added this to the Gutenberg 22.2 milestone Nov 13, 2025
@github-actions github-actions bot removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 13, 2025
gutenbergplugin pushed a commit that referenced this pull request Nov 13, 2025
@jorgefilipecosta @mcsf
@youknowriad @gutenbergplugin
Fix: Custom font size taking over fit text. (#73241)
201c4c9 
Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: mrwweb <mrwweb@git.wordpress.org>
@github-actions github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 201c4c9

pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Nov 18, 2025
@ellatrix
Sync packages for WP 6.9 RC 2.
2b31e8f 
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

- [Block Bindings: Add unit test coverage for `core/post-data` source](WordPress/gutenberg#73055)
- [Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
- [Notes: Collapse note on blur](WordPress/gutenberg#73158)
- [Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
- [Fix navigation tag entity binding](WordPress/gutenberg#73255)
- [DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
- [Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
- [Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
- [Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
- [Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
- [Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
- [Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
- [Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
- [Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)

Developed in #10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Fixes #64267.
Props priethor.

git-svn-id: https://develop.svn.wordpress.org/trunk@61262 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Nov 18, 2025
@ellatrix
Sync packages for WP 6.9 RC 2.
376c614 
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

- [Block Bindings: Add unit test coverage for `core/post-data` source](WordPress/gutenberg#73055)
- [Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
- [Notes: Collapse note on blur](WordPress/gutenberg#73158)
- [Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
- [Fix navigation tag entity binding](WordPress/gutenberg#73255)
- [DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
- [Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
- [Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
- [Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
- [Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
- [Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
- [Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
- [Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
- [Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)

Developed in WordPress/wordpress-develop#10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Fixes #64267.
Props priethor.
Built from https://develop.svn.wordpress.org/trunk@61262


git-svn-id: http://core.svn.wordpress.org/trunk@60574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Nov 18, 2025
@ellatrix
Sync packages for WP 6.9 RC 2.
8dded78 
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

- [Block Bindings: Add unit test coverage for `core/post-data` source](WordPress/gutenberg#73055)
- [Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
- [Notes: Collapse note on blur](WordPress/gutenberg#73158)
- [Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
- [Fix navigation tag entity binding](WordPress/gutenberg#73255)
- [DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
- [Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
- [Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
- [Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
- [Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
- [Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
- [Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
- [Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
- [Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)

Developed in WordPress/wordpress-develop#10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Fixes #64267.
Props priethor.
Built from https://develop.svn.wordpress.org/trunk@61262


git-svn-id: https://core.svn.wordpress.org/trunk@60574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Nov 18, 2025
@dream-encode
Editor: Sync packages for WP 6.9 RC 2.
61f6648 
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

[Block Bindings: Add unit test coverage for core/post-data source](WordPress/gutenberg#73055)
[Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
[Notes: Collapse note on blur](WordPress/gutenberg#73158)
[Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
[Fix navigation tag entity binding](WordPress/gutenberg#73255)
[DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
[Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
[Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
[Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
[Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
[Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
[Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
[Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
[Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)
Developed in #10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Reviewed by davidbaumwald.
Merges [61262] to the 6.9 branch.

Props priethor, ellatrix.
See #64267.

git-svn-id: https://develop.svn.wordpress.org/branches/6.9@61263 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Nov 18, 2025
@dream-encode
Editor: Sync packages for WP 6.9 RC 2.
fe3388e 
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/.

[Block Bindings: Add unit test coverage for core/post-data source](WordPress/gutenberg#73055)
[Block Bindings: Error handling for external sources.](WordPress/gutenberg#72585)
[Notes: Collapse note on blur](WordPress/gutenberg#73158)
[Border-radius values triggers unintended px conversion](WordPress/gutenberg#73324)
[Fix navigation tag entity binding](WordPress/gutenberg#73255)
[DataViews: ensure primary actions are not wrapped in the list layout](WordPress/gutenberg#73345)
[Fix: Fit Text may overflow into the padding area.](WordPress/gutenberg#73327)
[Merge "Icon Size" and "Icon size" translation strings](WordPress/gutenberg#73325)
[Notes: Improve delete confirm message for replies](WordPress/gutenberg#73173)
[Fix: Custom font size taking over fit text.](WordPress/gutenberg#73241)
[Fix a11y of descriptions and alerts for "Invalid" Nav Items](WordPress/gutenberg#73177)
[Stretchy text: Hide variations in Block Inspector (hack)](WordPress/gutenberg#73238)
[Update button label from "Add new note" to "Add new reply"](WordPress/gutenberg#73189)
[Notes: Fix first note creation with pinned sidebar](WordPress/gutenberg#73164)
Developed in WordPress/wordpress-develop#10528.
See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches.

Reviewed by davidbaumwald.
Merges [61262] to the 6.9 branch.

Props priethor, ellatrix.
See #64267.
Built from https://develop.svn.wordpress.org/branches/6.9@61263


git-svn-id: http://core.svn.wordpress.org/branches/6.9@60575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcsf mcsf mcsf approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

No one assigned

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core [Block] Stretchy Text [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 22.2

Development

Successfully merging this pull request may close these issues.

Fit Text Block Variation doesn't work if underlying block has explicit font size

3 participants

@jorgefilipecosta @mcsf