Skip to content

Conversation

@PaulAsaf2
Copy link
Contributor

Maybe I wrong but I didn't see that the price was called and suggested that the priceWithoutTax should be instead one.

What?

Closes

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After

Maybe I wrong but I didn't see that the `price` was called and suggested that the `priceWithoutTax` should be instead one.
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @PaulAsaf2.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: PaulAsaf2.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 13, 2025
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @PaulAsaf2! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka requested a review from luisherranz November 13, 2025 12:29
@Mamaduka Mamaduka added [Type] Developer Documentation Documentation for developers [Feature] Interactivity API API to add frontend interactivity to blocks. labels Nov 13, 2025
Copy link
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thanks for the fix, Paul!

@luisherranz
Copy link
Member

If you want to link your wordpress.org account so that the contribution counts, let me know and I'll wait before merging it.

@PaulAsaf2
Copy link
Contributor Author

If you want to link your wordpress.org account so that the contribution counts, let me know and I'll wait before merging it.

If we can approve without my wordpress.org account, I'd like this variant. Because I don't have one and I simple want to change the article what I read and nothing more. :)

@luisherranz
Copy link
Member

Sure! Thanks 🙂

@luisherranz luisherranz merged commit 30f9c3b into WordPress:trunk Nov 17, 2025
41 of 44 checks passed
@github-actions
Copy link

Congratulations on your first merged pull request, @PaulAsaf2! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 22.2 milestone Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Interactivity API API to add frontend interactivity to blocks. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants