Skip to content

Conversation

@chriszarate
Copy link
Contributor

What?

Real-time collaboration: Don't sync core/freeform (Classic) block without a defined content attribute.

Why?

A core/freeform block without a defined content attribute triggers an open modal. If we sync the block in this "not-ready" state, connected peers will experience an open modal as well.

How?

Withhold syncing until the content attribute is defined.

Testing Instructions

  1. Check out branch.
  2. Add a "Classic" block.
  3. Ensure modal only opens for the user who added the block.

Screenshots or screencast

Before

classic-before.mov

After

classic-after.mov

@chriszarate chriszarate requested a review from nerrad as a code owner October 27, 2025 22:35
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@chriszarate chriszarate added [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration [Type] Experimental Experimental feature or API. labels Oct 27, 2025
@github-actions
Copy link

Flaky tests detected in 802e899.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18857912632
📝 Reported issues:

@ingeniumed ingeniumed merged commit ce99ef5 into wpvip/rtc-plugin Oct 27, 2025
39 of 40 checks passed
@ingeniumed ingeniumed deleted the fix/freeform-block-modal-state branch October 27, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration [Type] Experimental Experimental feature or API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants