Real-time collaboration: Don't sync core/freeform block without content attribute
#72732
+66
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Real-time collaboration: Don't sync
core/freeform(Classic) block without a definedcontentattribute.Why?
A
core/freeformblock without a definedcontentattribute triggers an open modal. If we sync the block in this "not-ready" state, connected peers will experience an open modal as well.How?
Withhold syncing until the
contentattribute is defined.Testing Instructions
Screenshots or screencast
Before
classic-before.mov
After
classic-after.mov