Real-time collaboration: Ensure block attribute is Y.Text #72731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Real-time collaboration: Ensure block attribute from CRDT doc is a
Y.Textinstance before passing it tomergeRichTextUpdate.Why?
Our assumption that an attribute is represented in the CRDT doc as a
Y.Textinstance was based on the incoming block name, which may have changed. For example, a block can be transformed fromcore/freeformtocore/paragraph(both of which carry acontentattribute).When this happens, we can encounter a fatal error in
mergeRichTextUpdateby assuming a primitive string is aY.Textinstance.How?
instanceofcheck.Testing Instructions