Fix creating templates for posts with long slugs #71838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
commented
Sep 23, 2025
| className={ `${ baseCssClass }__info` } | ||
| > | ||
| { suggestion.link } | ||
| { safeDecodeURI( suggestion.link ) } |
Member
Author
There was a problem hiding this comment.
This is a drive-by related fix that improves display of the URL with an urlencoded slug. The original looks like this:
and the fixed UI looks like this:
We could also use the filterURLForDisplay helper, which does additional processing on the URL.
Member
There was a problem hiding this comment.
The filterURLForDisplay will give us slightly different text, without the protocol.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +53 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
Member
|
I believe there are additional areas where similar fixes may be necessary. One area is the Templates dropdown in the post editor. I think that until very recently, REST API didn't support non-Latin chars in template names/slugs. The workaround was to remove them. Screenshot
|
Member
Author
In the post slugs themselves, non-latin has been supported for 20 years, at least that's what |
tyxla
approved these changes
Sep 23, 2025
Member
tyxla
left a comment
There was a problem hiding this comment.
LGTM 👍
This solves the reported issue in my testing, and I'd only wish we had a test to ensure this doesn't happen again.
I'm happy to see this approach used in other places where it's necessary. No need to block this PR though IMO.
Member
|
@jsnajdr, this is the ticket I was referring to - WordPress/wordpress-develop#3819. |
Member
Author
This code ( |
Member
Author
|
I'm going to merge now, acknowledging that there will be followups. |
Member
|
Thanks, @jsnajdr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following bug when creating a template for a single post:
รีวิว Secretlab MAGNUS Pro Lamborghini Edition: เมื่อโต๊ะเกมมิ่งไม่ใช่แค่โต๊ะ แต่คือ “Supercar” ในห้องคุณWhat happened?
wp_posts.post_name) is limited to 200 chars. The new post's slug will be longer than that, especially when urlencoded. But the PHPsanitize_title_with_dashesfunction in Core will correctly truncate it to 200 chars, carefully respecting boundaries of utf-8 multiple-byte characters and of urlencoded octets.single-post-${ postSlug }. Here we are acting on urlencodedpostSlugand the urlencoded template slug (now longer than 200 chars) will be sent as payload of the REST request that creates the template.sanitize_title_with_dashesis careful only when dealing with a string that's not urlencoded. It correctly truncates and encodes raw utf-8 characters. But an urlencoded string will be truncated bluntly, and we're left with a slug that's not a valid urlencoded string. It looks something like...%b8%81%e.create_itemfunction of the templates controller will crash. Requests to DELETE the new template will be rejected by the Apache server itself, because the URL contains the wrongly encoded slug.I'm fixing this by decoding the original post slug before appending the prefix. Then the REST request will contain a slug string with raw utf-8 characters, and
sanitize_title_with_dasheswill be able to truncate it nicely.We should also do a companion Core patch that addresses the crashes. But this Gutenberg fix is good enough to get rid of the issue.